mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <a...@mesosphere.io>
Subject Re: Review Request 30931: Added flags to logs at master and slave startup.
Date Tue, 24 Feb 2015 09:27:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review73781
-----------------------------------------------------------

Ship it!


Minor style nits, otherwise it seems the RR converges to its final state.


include/mesos/type_utils.hpp
<https://reviews.apache.org/r/30931/#comment120193>

    I don't think we use extra newlines here. Check `master/master.hpp` or `master/contender.hpp`.



include/mesos/type_utils.hpp
<https://reviews.apache.org/r/30931/#comment120194>

    Here and below, kill extra newlines.


- Alexander Rukletsov


On Feb. 23, 2015, 11:34 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30931/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 11:34 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-2323
>     https://issues.apache.org/jira/browse/MESOS-2323
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added flags to logs at master and slave startup.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 
>   src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 
>   src/master/master.cpp 713307e1be596651283cc2cc95f114c42ad34a5e 
>   src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 
> 
> Diff: https://reviews.apache.org/r/30931/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message