mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 30911: Updated the filter abstraction for Resources.
Date Mon, 23 Feb 2015 22:12:46 GMT


> On Feb. 23, 2015, 8:14 p.m., Jie Yu wrote:
> > src/common/resources.cpp, line 491
> > <https://reviews.apache.org/r/30911/diff/4/?file=871467#file871467line491>
> >
> >     Make sure this is less than 80 chars in one line. I cannot tell from the review
board:)

Rookie mistake, sorry about that. Fixed.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30911/#review73648
-----------------------------------------------------------


On Feb. 23, 2015, 10:12 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30911/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 10:12 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2348
>     https://issues.apache.org/jira/browse/MESOS-2348
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See [JIRA Ticket](https://issues.apache.org/jira/browse/MESOS-2348).
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp c242bcc29c490841354d6fdc8d0de16eeea602ed 
>   src/common/resources.cpp 625922dd1abe2420736867c6043ca39be4e526ef 
>   src/master/allocator/mesos/hierarchical.hpp 2680d6231927867d5a8d75cbc42b81d6c75fc7f2

>   src/master/master.hpp a466f9299f116e1c3aae6fc79c73c9c165383769 
>   src/master/validation.cpp cd1052adc877cf698f5f627eef6ff4008aa573d5 
>   src/slave/slave.cpp 0374ca061cb53dc7e3338366aa41b1c15fb3231c 
>   src/tests/hierarchical_allocator_tests.cpp eeecfb64540b16666915074aaffaa5d506b203bc

>   src/tests/resources_tests.cpp 3f98782fd437dba808d720bf8e9b94b8fa7e0feb 
> 
> Diff: https://reviews.apache.org/r/30911/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message