mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 31315: Wait for status acknowledgement before getting master metrics
Date Mon, 23 Feb 2015 20:33:30 GMT


> On Feb. 23, 2015, 8:32 p.m., Ben Mahler wrote:
> > src/tests/master_slave_reconciliation_tests.cpp, lines 238-239
> > <https://reviews.apache.org/r/31315/diff/1/?file=873074#file873074line238>
> >
> >     How about:
> >     
> >     ```
> >     // Before we obtain the metrics, ensure that the master finishes
> >     // processesing the status update and increments its Counters.
> >     Clock::pause();
> >     Clock::settle();
> >     ```

That is, I'm hoping to avoid setting up an expectation on the acknowledgement, as it's further
removed from ensuring that the master finishes processing the update.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31315/#review73659
-----------------------------------------------------------


On Feb. 23, 2015, 7:56 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31315/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 7:56 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2366
>     https://issues.apache.org/jira/browse/MESOS-2366
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Wait for status acknowledgement before getting master metrics
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp 230f5293f4906e09eb55db128df4a19b1e308428

> 
> Diff: https://reviews.apache.org/r/31315/diff/
> 
> 
> Testing
> -------
> 
> 300 repeats without failure of the test under a debugger.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message