mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 31308: mesos: Fixed compilation problems caused by mesos::internal namespace removal.
Date Mon, 23 Feb 2015 19:01:41 GMT


> On Feb. 23, 2015, 11 a.m., Kapil Arya wrote:
> > src/tests/port_mapping_tests.cpp, line 82
> > <https://reviews.apache.org/r/31308/diff/3/?file=872983#file872983line82>
> >
> >     Just looked at the pastebin file (Thanks!), can we either replace the entire
`using mesos::internal::slave::*` code block with `using namespace mesos::internal::slave`
or remove the new code block and add the missing members using `using mesos::internal::slave::XYZ`?

we really should avoid using namespace. i know we don't but our style guide says we do. so
we should make some token effort on this.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/#review73626
-----------------------------------------------------------


On Feb. 23, 2015, 9:37 a.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31308/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 9:37 a.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/tests/port_mapping_tests.cpp a03de23e9833e8e3ec6b4a18b007811ac2b2b764 
> 
> Diff: https://reviews.apache.org/r/31308/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message