mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 31250: Expose the number of processes and threads in a container when cgroup is enabled.
Date Mon, 23 Feb 2015 17:43:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31250/#review73591
-----------------------------------------------------------



src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/31250/#comment119988>

    s/itto/it to/



src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/31250/#comment119990>

    It's hitting the kernel: I'm not sure how it internally keeps track of the processes/threads
in a cgroup, I would hope that it's not a list but....



src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/31250/#comment119991>

    This is hard-coded to true already and is soon to be removed, I believe. Can you check
if this is all necessary?



src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/31250/#comment119993>

    Why is this a containerizer test - could you not test just the cpu isolator without bringing
up an entire cluster?



src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/31250/#comment119994>

    what's the purpose of the while loop - can't you just block on the last sleep?


- Ian Downes


On Feb. 20, 2015, 5:12 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31250/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2015, 5:12 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: mesos-2103
>     https://issues.apache.org/jira/browse/mesos-2103
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ian, as discussed, I put the logic in cpu isolator for now until linux launcher sees
more and more need to report isolator-independent cgroup usage.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 507845c493f65e154214fc7e562206e452990469 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp e724b128f204e64a41561679c2797f81f64d1ab7

>   src/tests/containerizer_tests.cpp 06788493c263e623644f8d4df8cca44a74800ebb 
> 
> Diff: https://reviews.apache.org/r/31250/diff/
> 
> 
> Testing
> -------
> 
> added a new test. the test is end-to-end so that future replacement of the actual logic
won't require a change.
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message