mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 30931: Added flags to logs at master and slave startup.
Date Mon, 23 Feb 2015 15:58:44 GMT


> On Feb. 23, 2015, 2:34 p.m., Till Toenshoff wrote:
> > src/common/type_utils.cpp, line 208
> > <https://reviews.apache.org/r/30931/diff/4/?file=863302#file863302line208>
> >
> >     Maybe add a single space?

I followed the format of *curl localhost:5050/state.json* which does not have any spaces.


> On Feb. 23, 2015, 2:34 p.m., Till Toenshoff wrote:
> > src/slave/slave.cpp, line 176
> > <https://reviews.apache.org/r/30931/diff/4/?file=863304#file863304line176>
> >
> >     How about supporting Mesos local and possibly the test as well?

Is already automatially provided by the previous version as in both cases the calls go via
master/slave intialize as well.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review73563
-----------------------------------------------------------


On Feb. 13, 2015, 4:10 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30931/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 4:10 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-2323
>     https://issues.apache.org/jira/browse/MESOS-2323
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added flags to logs at master and slave startup.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 
>   src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 
>   src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 
>   src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 
> 
> Diff: https://reviews.apache.org/r/30931/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message