mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 31236: Re-introduce "internal" namespace for src/*.
Date Sun, 22 Feb 2015 22:10:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31236/#review73463
-----------------------------------------------------------



src/common/factory.hpp
<https://reviews.apache.org/r/31236/#comment119800>

    Was this in the code pre-30295 that way?


- Benjamin Hindman


On Feb. 22, 2015, 9:39 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31236/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2015, 9:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, Niklas Nielsen, and Vinod
Kone.
> 
> 
> Bugs: MESOS-2371
>     https://issues.apache.org/jira/browse/MESOS-2371
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reverted 30295 and 30300.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor.hpp cf82b04f9c3f7930fe4fdf74c13d3ffd2009bffe 
>   include/mesos/scheduler.hpp 31256c1c471232b5d879290e1b8ad914d26cf7a0 
>   include/mesos/values.hpp e9576779dad84c1783cfa4c8864d94d7135946dc 
>   src/authentication/cram_md5/authenticatee.hpp 33119160cea0bdf41a820c61c6fcbef7766d7ba3

>   src/authentication/cram_md5/authenticator.hpp 7578ea160903206628672f5ed84b6032c9a38c0a

>   src/authentication/cram_md5/auxprop.hpp d036b111711affae6e49a74f30ca769346765e58 
>   src/authentication/cram_md5/auxprop.cpp 5ff9755814f439712652b336fd51d64cea2cf433 
>   src/authorizer/authorizer.hpp 66ddb922511aee34063f9efe8371d3fc31af150f 
>   src/authorizer/authorizer.cpp 4f2b6a788df00ad9236f346c6b7e123ccfbe57f6 
>   src/cli/execute.cpp c55e961e60a106acaca35cd75b290990d75f804c 
>   src/cli/resolve.cpp 77bd4439f696bf16407a84243980834080af8f88 
>   src/common/attributes.hpp 844bdbfe7df14ff7b9912697937c18e7e57f482d 
>   src/common/attributes.cpp 33da50ca535756f99bc6689b26fe617d121975cc 
>   src/common/build.hpp 9765c8f3843b1da61db778fde1ddc075a5f99e63 
>   src/common/build.cpp 90bd7192ac266e21f24eadf08945adeaa85b0f84 
>   src/common/date_utils.hpp b11c8e093d993ee69859437a75976566e7119acc 
>   src/common/date_utils.cpp a148fd8763ea64593dc08380cf65e32c7ee96c7f 
>   src/common/factory.hpp 26f545b0edecd6a95dd18f799900940fb02d45ba 
>   src/common/http.hpp bdb5948a850ac9dda066dcb895c092d2108f62a5 
>   src/common/http.cpp 4b6040837a1532b3264a1a3a38b618841cc19961 
>   src/common/lock.hpp fbe04e0e8b0adc925bbb808c5fb299085cc69b36 
>   src/common/lock.cpp a52d3ff917cbb624f072e9dec4c4da656028f1fe 
>   src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5 
>   src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36 
>   src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f 
>   src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 
>   src/common/values.cpp 242f2a090d5d654d7efba2129eb7b7b7cd390029 
>   src/credentials/credentials.hpp 130beed342b508049fa02655ff72ba3467eb386e 
>   src/docker/docker.cpp 94f16e701f89367b599f0bd8f44c2f1de21a8e20 
>   src/examples/balloon_framework.cpp 08bb613e8296cfbe4fca98fa9856c2892653eb1f 
>   src/examples/load_generator_framework.cpp 16d278278df9eac5ee18d853f10c918751dbebf7

>   src/examples/low_level_scheduler_libprocess.cpp 986b175e86e153c315d0bea03f602d3855352d3e

>   src/examples/low_level_scheduler_pthread.cpp d69e68b9f6d768ebb7961ee53f10d74574195606

>   src/examples/test_authentication_modules.cpp 5ff58d2f824cb527ca6faa906aec96cbb5159d8c

>   src/examples/test_framework.cpp 0a4fde50cc533f54a5dbeb2899cbe3eeb6f133cb 
>   src/examples/test_isolator_module.cpp a66dc74de24d117dbcf9a3063bf5e2f69dbb1138 
>   src/exec/exec.cpp 8250bd4ec9028fb4667b9c703a2bb780fbf2171e 
>   src/files/files.hpp c8322d1381b6ba0e52bd29a4291fd3a786ce5fe0 
>   src/files/files.cpp 58a74b10af65ee30b7035ff00725d0f8e98529ea 
>   src/health-check/main.cpp 260b872272955f7ee20c0cc1d53d578d7ad2b731 
>   src/hook/manager.hpp a6594c180e772beccaf5beeaafc5cc02f69621a4 
>   src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b 
>   src/java/jni/org_apache_mesos_Log.cpp 3261b616eac6b785a80f828036b1b3859a93e4ff 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp d7e6cb5fcb39981471f00a90b4107e4059aadd93

>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 27e8905bd1804922b9c64e4ababb7ea98d8c4103

>   src/java/jni/org_apache_mesos_state_LogState.cpp dc1e49dcc722bc518159b61ca9f4869410589418

>   src/java/jni/org_apache_mesos_state_Variable.cpp b600996ac6872970516e22447db0157c64140214

>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 7b81760b3e7f9c6a6a4bc6e0bddf50c688a32b8e

>   src/jvm/jvm.cpp 38fedfcab0a415ad57f8c4ae6b92e3cac0900a2b 
>   src/launcher/executor.cpp f5db28cc155691f50cc00484db48a04502face8c 
>   src/launcher/fetcher.cpp 5b2d86d1867b25bf71461fd73df91b089002325b 
>   src/linux/cgroups.cpp a307e27c5840270e28cced2d5aeb90c6679bff1d 
>   src/linux/fs.hpp 9368d36fbe33c998033cbcd11628c19b363b5074 
>   src/linux/fs.cpp d17d3ab40719d94e1a62deb5aa564dfdcac7489b 
>   src/local/flags.hpp 16be2adafc125a658777dedc3bb96ec48cfa5064 
>   src/local/local.hpp 053434a91e20e3427bdf4773024a13f82980392f 
>   src/local/local.cpp 1ef04b8a1c890d7ca52a127be8e6d9967e4cd332 
>   src/local/main.cpp 7f12142c16a7be30617072e94a6d8257ecee249d 
>   src/log/catchup.hpp 9767c2416968a12fc7a37a3f54e0d22cd62b0750 
>   src/log/catchup.cpp c33ecd85f6d0d78e7d96e4c75ac48c9e6bd60827 
>   src/log/consensus.hpp ee9e9081ffe2a5f18433d9eff1a2e2cf17c81863 
>   src/log/consensus.cpp 7e33c693259cdb9dc359a7d25219b2047df390d9 
>   src/log/coordinator.hpp e00d34dd8779cd38571b6c8333a7c86bb6c9d6a4 
>   src/log/coordinator.cpp b97e133a7458b57dd94b99af385585cec5b2de8d 
>   src/log/leveldb.hpp 8f5df5bdfb08de02e4129494fba188f97c3b8010 
>   src/log/leveldb.cpp 1d679425c6df3498be67d048bc05d02ffe03a636 
>   src/log/log.hpp fac7d97b5cd57ff6467874cccce9e95018caf035 
>   src/log/log.cpp cd7b6a8b1f1471b8f0ab198de646fa7be18c4af5 
>   src/log/main.cpp 2027ba0aefc1d68abc59463245cb7820f37ac372 
>   src/log/recover.hpp 11e144e3c5d2ff2b171ed06fac0e8cbafddedc82 
>   src/log/recover.cpp 3e175f3bbd598230c54f3d1a5cda2ca6e137c6a8 
>   src/log/replica.hpp b2602083564447cf75827257a2548c1b5aeb49e2 
>   src/log/replica.cpp 83cb3e7d9271ab4e4c9e0df98824aa933190a4d9 
>   src/log/storage.hpp 5e81f4e9774ad239145019320cf991fcf51a9da5 
>   src/log/tool.hpp 39051595e8a8299bc7da97fd8c13b2038df59aa2 
>   src/log/tool/benchmark.hpp d519a692997ed4faff1e1cde44105254d54b435e 
>   src/log/tool/benchmark.cpp 096298ec6fc328e463c3bcd57716d8745bcd1c94 
>   src/log/tool/initialize.hpp f55225f416364a72b093fa05c5eddfa291af41ff 
>   src/log/tool/initialize.cpp f3d6337f6f7817ec6e1bc8b3a2481c1f6a1a8250 
>   src/log/tool/read.hpp 1a077dedcfcc8c3e6c41c536efcb57c6db0647a8 
>   src/log/tool/read.cpp 4c6c30db5dbd5bde2cf3b452b07a6b4011d39b99 
>   src/log/tool/replica.hpp 9d8dfd0741ed66bc3870cfe2a297f198f61c6837 
>   src/log/tool/replica.cpp 0edc70adc6c5f689d4ab17fe70c546b0ac2b92cf 
>   src/logging/flags.hpp 30b59b60e4086f0f44ad70af176b9d61f0536c6c 
>   src/logging/logging.hpp 1984f9b14b1ae3c63554884803e55f840cdd1268 
>   src/logging/logging.cpp 9ae91d1dd6245e078acc624372f657a83a9ca255 
>   src/master/allocator/allocator.hpp c2461a32e18dbafe637f37180f86bfa2e1d78735 
>   src/master/allocator/mesos/allocator.hpp 99b40a01749b77fc7c1fa025a7ac81d5cca6272f 
>   src/master/allocator/mesos/hierarchical.hpp 2680d6231927867d5a8d75cbc42b81d6c75fc7f2

>   src/master/allocator/sorter/drf/sorter.hpp 966fe03de389246dc71e933f9a51ad5b55f2834d

>   src/master/allocator/sorter/drf/sorter.cpp 7baee453848c7587472b2e9358c9e4ee6df6e860

>   src/master/allocator/sorter/sorter.hpp 8cd70dd91f72109222d8a0cd67cbf66ee4188ab5 
>   src/master/constants.hpp ad3fe819c948c3f86749b112281704b5ea20d4b1 
>   src/master/constants.cpp d3d0f71be2738d37255359c175d0ca6e76c6c98f 
>   src/master/contender.hpp c009de3726d330072bbe7e9a1d7a6f40f60ada7b 
>   src/master/contender.cpp 594a7646c759a821823d1fa12f3cc640980d22f5 
>   src/master/detector.hpp 1373845aa71902b52517500d3d2d8b0870c684d3 
>   src/master/detector.cpp 053b0a7e1b62bfe11e263cff43f5d155580d8696 
>   src/master/flags.hpp 51a6059b05be25cc34f6a618da27dbca59144cfc 
>   src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba 
>   src/master/main.cpp a1efd2bd471aa8e0a041564ff65ac011047a5ca6 
>   src/master/master.hpp 6a39df04514c756415354fae66c5835ada191c52 
>   src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 
>   src/master/metrics.hpp 326eb36d9ce7ace8bdd11fa9c2eefe9793829e37 
>   src/master/metrics.cpp 3ed84e24a88f47c328960ecbad9974aaa1d76c21 
>   src/master/registrar.hpp 701b1071bbad35872bbf924491d658899396c810 
>   src/master/registrar.cpp 2bfc053595cf93890d19ca4ccd9a4a1ee44edc26 
>   src/master/registry.proto 29a309763bca9db76c443d7c039ca152a2afbc5b 
>   src/master/repairer.hpp 236b8decda618c13aa06c4e2d2a8d0b4ad89a7cc 
>   src/master/repairer.cpp 201ac25f063aeebacb3357115176e44406dcd240 
>   src/master/validation.hpp c312cdcb1f40e2a19fbf615431a3c2127253c28e 
>   src/master/validation.cpp acc35b25c93f2d3900d79c3070b1d681416ed66b 
>   src/messages/log.proto 12b3572e0fe0e30c5eff20c7af27eb3d7cfe8f4b 
>   src/messages/messages.hpp 25769b797ec9bd1a1c348c467616aef8407c45d6 
>   src/messages/messages.proto 58484ae45071a80afd2b11803dd66a88f88ad9ed 
>   src/messages/state.proto 7fc4883b9fe590afbbb0261988c929c3b1f8f676 
>   src/module/manager.hpp f071678aca0729c14147b16f00a6f1e0daf9094e 
>   src/module/manager.cpp 44a3e6587d6dbf8f75f8e3f41896f68a77362619 
>   src/sched/constants.hpp d36d087b3abcd68ba67414d25e810ccc583afc03 
>   src/sched/constants.cpp bc85d693180736b5aa6d03304fb58b2029480769 
>   src/sched/flags.hpp bfe01a32db2cdd9783902a418c16ff5e88cadc1b 
>   src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905 
>   src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182 
>   src/slave/constants.hpp 12d6e92b814076fd423a7738e030dc6ce6954761 
>   src/slave/constants.cpp 7868befe5957fabff466c794e5a33f795a4f352f 
>   src/slave/containerizer/composing.hpp 6518f2a77f28111d959625386e0911e0293ff7a3 
>   src/slave/containerizer/composing.cpp 6e3007eda31afbd235eeabbe4c7e7b94c694b9a5 
>   src/slave/containerizer/containerizer.hpp fd08b2975f5aa9afe55874cb07ff56aad7d0078c

>   src/slave/containerizer/containerizer.cpp c453c33f13dfffbe18e8d8716b0b0eb69bf788eb

>   src/slave/containerizer/docker.hpp 70114dcef7a416ae904e95eb9ce365bcd866aebc 
>   src/slave/containerizer/docker.cpp 813ddf8c98622748b2da1b739bf122387abc4c79 
>   src/slave/containerizer/external_containerizer.hpp 5035454a355313014e84221621daa2ed33ca3161

>   src/slave/containerizer/external_containerizer.cpp 79b5fc6c648d40263599661a39bf93da91fcdc60

>   src/slave/containerizer/fetcher.hpp bfd98dbe16e2bd5df3e2c8e9b10e303654f33446 
>   src/slave/containerizer/fetcher.cpp 6e6bce08d76bb8a5813c905e3ffeff9b2411fd6d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp 472edb2c60d53cda2ccb6ca01369960392e2e718

>   src/slave/containerizer/isolators/cgroups/cpushare.hpp f4ae1498b045ee6f6eb5cced81752f416650035b

>   src/slave/containerizer/isolators/cgroups/cpushare.cpp e724b128f204e64a41561679c2797f81f64d1ab7

>   src/slave/containerizer/isolators/cgroups/mem.hpp 92f197bdf8cd110745ea2b81aa320aa891a61941

>   src/slave/containerizer/isolators/cgroups/mem.cpp c0221273f62585a840cfe3ee7cd58788b1a38ff9

>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 4ad6cb9ab6a76e260754ebcecc0d5d590edaa2ea

>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 331a10bbc476361f1d8cc03dfd4ac96ab581485e

>   src/slave/containerizer/isolators/filesystem/shared.hpp 779caca2365a44a0256c32b5f18a83130a0c68fa

>   src/slave/containerizer/isolators/filesystem/shared.cpp cfd1e96cf454c513a023c0779480e69cad3808ab

>   src/slave/containerizer/isolators/namespaces/pid.hpp 88227a3237162c030646e13fd6d77793604da175

>   src/slave/containerizer/isolators/namespaces/pid.cpp ae52404260611c77ae82de1732927f1f2c49a67c

>   src/slave/containerizer/isolators/network/helper.cpp 291cbdd8c254cec39ae6e5488a4cb00cceb9fe1b

>   src/slave/containerizer/isolators/network/port_mapping.hpp d0d56193de79b020b83b7873fdc99bee4aecaf5e

>   src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44

>   src/slave/containerizer/isolators/posix.hpp f8716066b7057c8d884ee8df48cb692839c23f9f

>   src/slave/containerizer/isolators/posix/disk.hpp f5b294eaa31782fc93c27858811b47a910fcac3f

>   src/slave/containerizer/isolators/posix/disk.cpp ee53063401e639d68a85f56259ac8bdad6229772

>   src/slave/containerizer/launcher.hpp f292e2d2a56969e4044fcb0867433707bb232a2f 
>   src/slave/containerizer/launcher.cpp f413a5152a7688038913a6ec2ab6dd474e534b20 
>   src/slave/containerizer/linux_launcher.hpp 37304222323d3089b95df605d2077a3f88d11277

>   src/slave/containerizer/linux_launcher.cpp 3fdfb5709d48d079bbe904a91b773f131131b08d

>   src/slave/containerizer/mesos/containerizer.hpp 074a2d82dcd882e52f8cd62ed7493295596acb26

>   src/slave/containerizer/mesos/containerizer.cpp d5b90d12d63becfeb4c3efa9c6f5d826417f582c

>   src/slave/containerizer/mesos/launch.hpp 01765561040402713cfc8ae8e55f37668114b8c3 
>   src/slave/containerizer/mesos/launch.cpp a0ff1b7d6bd29015f207f9d43e18c33411737ad3 
>   src/slave/containerizer/mesos/main.cpp 136390db52669cccac4e9049684dfe8860658dea 
>   src/slave/flags.hpp ddb32593566b71bcf0b66adeeb889e43ef911084 
>   src/slave/gc.hpp d9f9d7b86d2e0b204822f5fd2eccd725519bbd4b 
>   src/slave/gc.cpp 6060c18138c040f8de16119fa9dbadd63b65740b 
>   src/slave/http.cpp ef6e64882282a9d7be252ccdc545ab96d6323c3b 
>   src/slave/main.cpp 173a1a3117901d61027fe27d5f411312ed9d9777 
>   src/slave/metrics.hpp e2ce845ec2229e1e6e71c710022551bec9d15029 
>   src/slave/metrics.cpp ee610b8a7d352c20e8a91bb86c8aa2c1f011e910 
>   src/slave/monitor.hpp 94f9ea6c84357a403139d8302226f606d1d34840 
>   src/slave/monitor.cpp c2c286cf6dad6bf1d281cc501848e4d883bd8bfa 
>   src/slave/paths.hpp eba398c5b3a13e6017407806b29ca14ffd2a3a5e 
>   src/slave/paths.cpp cf08c445b772cc1a98e8abdcb3db7be098035633 
>   src/slave/slave.hpp 91dae1074607993f85628d3ba3cde485097bd873 
>   src/slave/slave.cpp aec9525d7af1cc7383f1babeb7867cd8a63d1a4c 
>   src/slave/state.hpp e7276a503d54075f3eddd2e890e0aa4f3721ea00 
>   src/slave/state.cpp 24ab12c7f06000c3b04e6a826b5b891e2a9c2dfe 
>   src/slave/status_update_manager.hpp 44b60b508c2556537e3fc9358257b2a3d10cd4c2 
>   src/slave/status_update_manager.cpp 5b0192b688bdeb8cf3411da7aedbee72caf50a7d 
>   src/state/in_memory.hpp fea2e107dd6521fee3e45fbc69480f03513aff32 
>   src/state/in_memory.cpp 6f336161a2269866ee18ef0241cb8a121c2b93cf 
>   src/state/leveldb.hpp 379316ce150ef98248e7384bc52a9f2924a0dc7f 
>   src/state/leveldb.cpp 263a6b99bb405ea52f3abc608cb5180404854c55 
>   src/state/log.hpp 1558dad180015bbf1867d4d443fa1f2759fc9d37 
>   src/state/log.cpp 6069d129886095f0a08d3c15ca13703a70a97dc7 
>   src/state/protobuf.hpp 6f67c6a2a336c1861e0b9f5baa7a41241074d2f4 
>   src/state/state.hpp 878265da5556b0b43a519ba21de9f522eb71b88c 
>   src/state/storage.hpp f5cd607b47d44f72d72cbd0c5adb7368410b83d8 
>   src/state/zookeeper.hpp 9352a2182d21f04ea66a0a2a858e3a940754109a 
>   src/state/zookeeper.cpp e570a9b82de25025ee06350b7c54e86a27392c4b 
>   src/tests/attributes_tests.cpp 138d543e64ed74367e849dd42453d38336519796 
>   src/tests/authentication_tests.cpp 59d29549b2831a0a50478456d16fdc41022a221e 
>   src/tests/authorization_tests.cpp edae66d3de91d8a8eb3ed8fc940309a0e9f593f6 
>   src/tests/cgroups_isolator_tests.cpp 9fbde334f596f3673bb84657731c161ac6578c42 
>   src/tests/cgroups_tests.cpp 9d50a47c939f5f136c85fdcc555459512c6f2259 
>   src/tests/cluster.hpp ccd68dbcba480ee655d73df333f44d665154b602 
>   src/tests/common/http_tests.cpp b030a783c3932912dd431ad1fe24f488aa5d9460 
>   src/tests/composing_containerizer_tests.cpp 6bb49ea780b0fe79974e57b35f886ee82a1e3f1c

>   src/tests/containerizer.hpp f6fdb52552398cb1bd4c96dde6c7d6763d8ca618 
>   src/tests/containerizer.cpp 8341c20f42156c2ee9375a5536e02b8e7b76d75c 
>   src/tests/containerizer_tests.cpp 06788493c263e623644f8d4df8cca44a74800ebb 
>   src/tests/cram_md5_authentication_tests.cpp dd102dca6f37cc4a7d8c8a67bfb05bbe0e7da3b5

>   src/tests/credentials_tests.cpp 4210d315bae423cf27d181a633090c99d2f5bc62 
>   src/tests/disk_quota_tests.cpp 1d3aa0c395ddcd59a5072a5a47b3cf8ed05567ed 
>   src/tests/docker_containerizer_tests.cpp 8b212d4e6ed5a179ebadce1bdbbf3edde87d706c 
>   src/tests/docker_tests.cpp ae01a4e6fcd36cd6747d9c77d339403ebbb5c78a 
>   src/tests/environment.hpp 577952899bf5046659378873d2453ab7df92c39f 
>   src/tests/environment.cpp 0c2157b4465541afef21d622eacc38a0360c606e 
>   src/tests/exception_tests.cpp 7a41770c26519541fed10672e13ee833a2d6dd5e 
>   src/tests/external_containerizer_test.cpp d6c4437d8a9b4b46740c3a3a626908cd69081541

>   src/tests/fault_tolerance_tests.cpp efa5c57d98308e9d54723d361533b39b99551261 
>   src/tests/fetcher_tests.cpp fcbf7ad912f0b1b3d106a75a9dcb8213a0c69c07 
>   src/tests/files_tests.cpp 650f1b947d87b7e17651f7378369d3ade826e412 
>   src/tests/flags.hpp 3155d89b9c42a0e3b650703d7a0c553c1b00e010 
>   src/tests/flags.cpp 693c2bd1a3a302e53775c2b28d9b0a3fcd449c3e 
>   src/tests/fs_tests.cpp 0ea286b21788b8c32a2e961514f45d713decd77d 
>   src/tests/gc_tests.cpp c74287a29eaa8478c301ef3bcfd9af1e27a67b7e 
>   src/tests/group_tests.cpp 5344087ffb6a8313e046906b6e3b40fc3bc13d98 
>   src/tests/health_check_tests.cpp 7fcb2310e9e9d203b78925315ff71d3f7396f099 
>   src/tests/hierarchical_allocator_tests.cpp eeecfb64540b16666915074aaffaa5d506b203bc

>   src/tests/hook_tests.cpp dc6d289394e5718a37936e29ad6d988b52933f98 
>   src/tests/isolator.hpp 5ad338b031fd5e69ebad6cb861d4d33062cd492e 
>   src/tests/isolator_tests.cpp ab4bacc19f84ec9cba4576c95b43425ba352fd67 
>   src/tests/log_tests.cpp 8cbc4df5dac49eef4ab618f47862812266ed513d 
>   src/tests/logging_tests.cpp 0f2d30dcc048a8098b66bf65cb065917438542d3 
>   src/tests/main.cpp 0ab6be502e3c2c23b728c27dd5cbdd014da08cd5 
>   src/tests/master_allocator_tests.cpp df9ac24280514932dc118408b11adc806f548f5e 
>   src/tests/master_authorization_tests.cpp fadbd38f50c9587a9b1755d96a96e10c540264c5 
>   src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db

>   src/tests/master_slave_reconciliation_tests.cpp 5156898a4ec02a2ad0080ab768e360077f0ba0f1

>   src/tests/master_tests.cpp 3a9da68364fda25ac25565a1d2799f2dfaf736da 
>   src/tests/master_validation_tests.cpp e2b64267cb0df5c9944f27d01af90ae15a1f2432 
>   src/tests/mesos.hpp 60c70043c8266a422ffa03ab5a949da0bc822124 
>   src/tests/mesos.cpp d76ed8c837da162d782de84e935fe8e11e01d6b0 
>   src/tests/metrics_tests.cpp 3b2dc24b41293a5c539bfd0a0248d9c25fe654d5 
>   src/tests/module.hpp 5748add67ef7d194c7ca8521f505079b617ac139 
>   src/tests/module.cpp 3c9bab7a192a63adfa3cfc8fd1e29dada00f8095 
>   src/tests/module_tests.cpp a16ba994951ef581d703e96b14f4d95f483cb2cf 
>   src/tests/monitor_tests.cpp b640d89c8c91a83dce3ff08e65b8efaf493a419e 
>   src/tests/ns_tests.cpp b11a216b180103311fab462d7c460a5326d51575 
>   src/tests/partition_tests.cpp eb16a58c23e0c152212140841ed09cd7f6f139d6 
>   src/tests/paths_tests.cpp 07e8af56ea7e186b7daff8c7695e997edf325ad7 
>   src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679 
>   src/tests/protobuf_io_tests.cpp 92a090a221bcbdc7adc4ca3c717302c48c57902d 
>   src/tests/rate_limiting_tests.cpp 784ac76ee81918466de44196f5adc2b88adfee96 
>   src/tests/reconciliation_tests.cpp 4c97341a1e84b1504090e8b3fdd8b309abf65877 
>   src/tests/registrar_tests.cpp fd312930e33e332c3d5b6291c191050378694d9e 
>   src/tests/registrar_zookeeper_tests.cpp 7c9aa816bd2a3be00a4b339c71886bb8abbe97d6 
>   src/tests/repair_tests.cpp 1aad5c15a1c1111c481d5d97f6f65b6ba1f3706c 
>   src/tests/resource_offers_tests.cpp 1ba73ba7f9c2cd042119a2bd47c16f152ebc65fa 
>   src/tests/resources_tests.cpp 3f98782fd437dba808d720bf8e9b94b8fa7e0feb 
>   src/tests/scheduler_tests.cpp 9071a852bc0255a9400f88834d0ad3b3a7463c3a 
>   src/tests/script.hpp d25b1e282af92592a2de9b24b931b428d126b7c6 
>   src/tests/script.cpp ddbec76a2275fef543f0fa59f47496901d6c42e7 
>   src/tests/shutdown_tests.cpp 9017517bf7a5a79c5d4ca63fc1b23b2c5403b538 
>   src/tests/slave_recovery_tests.cpp 8210c52afd03e2a722657c45ef8ed2dae7988022 
>   src/tests/slave_tests.cpp 153d9d625a4a843d21e4cd6ea3b4fa06c4c440f2 
>   src/tests/sorter_tests.cpp 7ba32b78bdedf754f76f0695dfd1d86aa1f1b5bf 
>   src/tests/state_tests.cpp b30812322dd8ae507e1d45912ab559940ac5ee73 
>   src/tests/status_update_manager_tests.cpp 2158cfea98d238d462abeebd3d5fe2dec4f96470

>   src/tests/utils.hpp 3aea47c416c6604b7c4f83117e95add7f536eb35 
>   src/tests/utils.cpp 24274695f8d65d04a51e8ce61c1be03d1ced4510 
>   src/tests/values_tests.cpp dd59db83c91c1fc8596ebddff5e37138f834198e 
>   src/tests/zookeeper.hpp 615e23ae61cb4e4a513d56566223a4a61f1590b6 
>   src/tests/zookeeper.cpp 4f96dfadf1f3fef4943eaeff0dc154b58c48fe96 
>   src/tests/zookeeper_test_server.hpp cfc9706bd144a541318515e8e90ebc6be67f52bb 
>   src/tests/zookeeper_test_server.cpp 984b6a688ae26cfd539c00bb1649080ac41019eb 
>   src/tests/zookeeper_tests.cpp 40081efa7ee6c498fa07cd06391480deb752b6ea 
>   src/usage/main.cpp e987f0c7b8df6af662f9bd3c7b564f132aa1a33d 
>   src/usage/usage.hpp 77e9d16e46d1b665a491e893f2709d4115d293ba 
>   src/usage/usage.cpp 4ddf075153669baa1073a20ccd7e027254a123ab 
>   src/watcher/whitelist_watcher.hpp 654a27d7cac16ceaa5081a58c667b86b050c4e29 
>   src/watcher/whitelist_watcher.cpp e00b5c80aa388ba33ea73ab7e746ae795554d2b5 
> 
> Diff: https://reviews.apache.org/r/31236/diff/
> 
> 
> Testing
> -------
> 
> make check after the follow-up patch (https://reviews.apache.org/r/31279/) succeeds.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message