mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <>
Subject Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.
Date Sun, 22 Feb 2015 22:03:06 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 22, 2015, 10:03 p.m.)

Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone.


Adressed Adams comments.

Bugs: MESOS-2050

Repository: mesos


The initial design and implementation of the authenticator module interface caused issues
and was not optimal for heavy lifting setup of external dependencies. By introducing a two
fold design, this has been decoupled from the authentication message processing. The new design
also gets us back on track to the goal of makeing SASL a soft dependency of mesos.

Diffs (updated)

  include/mesos/authentication/authenticator.hpp f66217a 
  src/ d372404 
  src/authentication/cram_md5/authenticator.hpp 7578ea1 
  src/authentication/cram_md5/authenticator.cpp PRE-CREATION 
  src/authentication/cram_md5/auxprop.hpp d036b11 
  src/authentication/cram_md5/auxprop.cpp 5ff9755 
  src/master/master.hpp a466f92 
  src/master/master.cpp f10a3cf 
  src/tests/cram_md5_authentication_tests.cpp dd102dc 



make check


Till Toenshoff

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message