mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 29288: stout: Created IP address abstraction for different protocol families
Date Sat, 21 Feb 2015 15:21:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
-----------------------------------------------------------

(Updated Feb. 21, 2015, 3:21 p.m.)


Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and
Niklas Nielsen.


Bugs: MESOS-1919
    https://issues.apache.org/jira/browse/MESOS-1919


Repository: mesos


Description
-------

Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but
write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing
of the protocol headers differ.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b464e517bb1e7b6b381c6cd6c0466ed788a82615

  3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 425132e5d7c3770be4a5a39feea5a2f22179b871


Diff: https://reviews.apache.org/r/29288/diff/


Testing
-------

make check


Thanks,

Evelina Dumitrescu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message