mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 29507: Added Configurable Slave Ping Timeouts
Date Thu, 19 Feb 2015 00:33:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
-----------------------------------------------------------

(Updated Feb. 18, 2015, 4:33 p.m.)


Review request for mesos and Niklas Nielsen.


Changes
-------

Rebased, in preparation for part 2 (slave-side timeouts).


Bugs: MESOS-2110
    https://issues.apache.org/jira/browse/MESOS-2110


Repository: mesos


Description (updated)
-------

Added new --slave_ping_timeout and --max_slave_ping_timeouts flags
to mesos-master to supplement the DEFAULT_SLAVE_PING_TIMEOUT (15secs)
and DEFAULT_MAX_SLAVE_PING_TIMEOUTS (5).
   
These can be extended if slaves are expected/allowed to be down for
longer than a minute or two.
  
Beware that this affects recovery from network timeouts as well as
actual slave node/process failover.


Diffs (updated)
-----

  src/master/constants.hpp c386eab 
  src/master/constants.cpp 9ee17e9 
  src/master/flags.hpp 6c18a1a 
  src/master/master.cpp f4b6463 
  src/slave/constants.hpp 761cfaf 
  src/slave/constants.cpp 83d9fc1 
  src/slave/slave.cpp a8b2621 
  src/tests/fault_tolerance_tests.cpp f927d4a 
  src/tests/partition_tests.cpp fea7801 
  src/tests/slave_recovery_tests.cpp 7e2e63d 
  src/tests/slave_tests.cpp e7e2af6 

Diff: https://reviews.apache.org/r/29507/diff/


Testing (updated)
-------

Manually tested slave failover/shutdown with master using different --slave_ping_timeout and
--max_slave_ping_timeouts.
Ran unit tests with shorter non-default values for ping timeouts.


Thanks,

Adam B


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message