mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 31024: Changed the slave logic so that it always waits for containerizer update to finish.
Date Wed, 18 Feb 2015 19:07:00 GMT


> On Feb. 18, 2015, 6:53 p.m., Vinod Kone wrote:
> > src/slave/slave.hpp, line 280
> > <https://reviews.apache.org/r/31024/diff/1-3/?file=863795#file863795line280>
> >
> >     s/flushTasks/runTasks/ so that we don't add a new verb "flush"?

We already have 'runTask'. Sounds a little confusing if we have both 'runTask' and 'runTasks'.
Because of that, I still prefer 'flushTasks'. What do you think?


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31024/#review72975
-----------------------------------------------------------


On Feb. 18, 2015, 12:01 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31024/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 12:01 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Vinod Kone.
> 
> 
> Bugs: MESOS-998
>     https://issues.apache.org/jira/browse/MESOS-998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed the slave logic so that it always waits for containerizer update to finish.
> 
> The key idea is to leverage `executor->queuedTasks` when containerizer->update
is in progress.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 
>   src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 
>   src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 
>   src/tests/master_tests.cpp e69a7fb39e93a9a999e0991985f5d060b72aac65 
>   src/tests/registrar_zookeeper_tests.cpp 30d3cd8b1e7d56fbb326c9feccd4c3cbae2015de 
>   src/tests/scheduler_tests.cpp 080ec7236246794de6c8cc7356a06331c5e48cd5 
>   src/tests/slave_tests.cpp 21709e2858d91a2746e0343786f73dec22735da6 
> 
> Diff: https://reviews.apache.org/r/31024/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message