mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint
Date Wed, 18 Feb 2015 15:01:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30074/
-----------------------------------------------------------

(Updated Feb. 18, 2015, 4:01 p.m.)


Review request for mesos, Niklas Nielsen and Till Toenshoff.


Changes
-------

Following Ben's and Till's suggestions, the value for `executor_directory_max_allowed_age_secs`
now is part of metrics.


Bugs: mesos-2229
    https://issues.apache.org/jira/browse/mesos-2229


Repository: mesos


Description
-------

Adds and entry `max_allowed_age_secs` to the response of the `state.json` endpoint in the
slave. 

The max allowed age value is available only if it is set, which depends on the flag `--disk_watch_interval`
which by default runs every minute (So it will only be available after the first minute running).

Modifies the unit test `SlaveTest.StateEndpoint` so it takes into account the new entry.


Diffs (updated)
-----

  src/slave/metrics.hpp e2ce845ec2229e1e6e71c710022551bec9d15029 
  src/slave/metrics.cpp ee610b8a7d352c20e8a91bb86c8aa2c1f011e910 
  src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 
  src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 
  src/tests/slave_tests.cpp 21709e2858d91a2746e0343786f73dec22735da6 

Diff: https://reviews.apache.org/r/30074/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message