mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 31145: Fixed a CPU-intensive bug in libprocess' clock.
Date Wed, 18 Feb 2015 03:24:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31145/#review72887
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/src/clock.cpp
<https://reviews.apache.org/r/31145/#comment119010>

    s/'timer's/'timers'/
    s/'ticks's/'ticks'/



3rdparty/libprocess/src/clock.cpp
<https://reviews.apache.org/r/31145/#comment119011>

    Just to be so ultra explicit, a brief comment explaining a negative delay is okay, it
should cause 'tick' to fire immediately.


- Benjamin Hindman


On Feb. 18, 2015, 3:12 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31145/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 3:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2325
>     https://issues.apache.org/jira/browse/MESOS-2325
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is based on some discussions w/ benh and Joris' patch here:
> https://reviews.apache.org/r/30808/
> 
> The issue is outlined in the ticket. To fix this, we keep track of the scheduled '`ticks`'
and only schedule another if it's earlier than the other '`ticks`'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/clock.cpp b92d5de2631986506361e28c05cb6169e6632a70 
> 
> Diff: https://reviews.apache.org/r/31145/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message