mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 30958: PortMappingIsolator: Better ingress qdisc management on eth0 and lo.
Date Mon, 16 Feb 2015 18:52:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30958/#review72640
-----------------------------------------------------------



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/30958/#comment118685>

    Do you have a ticket explaining why this is needed?



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/30958/#comment118686>

    If the ingress qdisc is not installed by mesos, will you be removing it? That being said,
I want to understand the motivation for this in a JIRA.


- Jie Yu


On Feb. 13, 2015, 6:24 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30958/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 6:24 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> PortMappingIsolator: Better ingress qdisc management on eth0 and lo.
>     
> Remove ingress qdiscs on eth0 and lo after the last container exits. They will
> be added back when the next container comes in. This makes sure after a clean
> shutdown, the sytem will be clean.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44

> 
> Diff: https://reviews.apache.org/r/30958/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message