mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 29290: Created IP address abstraction for different protocol families
Date Thu, 12 Feb 2015 22:55:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review72259
-----------------------------------------------------------


Patch looks great!

Reviews applied: [29288, 29289, 29290]

All tests passed.

- Mesos ReviewBot


On Feb. 12, 2015, 8:01 p.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29290/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 8:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere,
and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1919
>     https://issues.apache.org/jira/browse/MESOS-1919
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6
field.
> I intend to use the same Classifiers, addition, removal and update of container filters,
but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing
of the protocol headers differ.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 82c6e4f693fe3e02d76d2865702d79f28c3e19b5 
>   src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36 
>   src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff

>   src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d 
>   src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2 
>   src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d 
>   src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba 
>   src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58 
>   src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905 
>   src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182 
>   src/slave/containerizer/isolators/network/port_mapping.cpp b860b17e59486cd6097183a4d3139fbd5c897b44

>   src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 
>   src/tests/master_contender_detector_tests.cpp 78b1a6a393a0c69ade12d7f74ee931254b9975db

>   src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561 
>   src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679 
> 
> Diff: https://reviews.apache.org/r/29290/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message