mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 30906: Added a metric for launcher's container destruction failure.
Date Thu, 12 Feb 2015 22:54:29 GMT


> On Feb. 12, 2015, 10:53 p.m., Alexander Rukletsov wrote:
> > src/slave/containerizer/linux_launcher.cpp, line 418
> > <https://reviews.apache.org/r/30906/diff/2/?file=862206#file862206line418>
> >
> >     Maybe it makes sense to mimic the directory structure in naming for simplicty
and consistency? How about "containerizer/linux_launcher/destroy_errors"?

What happens when we refactor and the directory structure changes?


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30906/#review72257
-----------------------------------------------------------


On Feb. 12, 2015, 8:07 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30906/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 8:07 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: MESOS-1690
>     https://issues.apache.org/jira/browse/MESOS-1690
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.hpp 37304222323d3089b95df605d2077a3f88d11277

>   src/slave/containerizer/linux_launcher.cpp 3fdfb5709d48d079bbe904a91b773f131131b08d

>   src/slave/containerizer/mesos/containerizer.cpp d5b90d12d63becfeb4c3efa9c6f5d826417f582c

> 
> Diff: https://reviews.apache.org/r/30906/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> No existing launcher tests to inject metrics test. Will work with @idownes to figure
how to write one.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message