mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.
Date Wed, 11 Feb 2015 02:16:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30850/#review71895
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/30850/#comment117816>

    s/resources is/resources are/



src/slave/slave.cpp
<https://reviews.apache.org/r/30850/#comment117815>

    Is this stringify going to capture all of the disk information or do you want a JSON representation?



src/slave/slave.cpp
<https://reviews.apache.org/r/30850/#comment117814>

    s/is/are/



src/tests/mesos.cpp
<https://reviews.apache.org/r/30850/#comment117817>

    Can you pull out the removal of 'process::' and just commit it as a patch on master?


- Ben Mahler


On Feb. 10, 2015, 11:10 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30850/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 11:10 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for checkpointed resources during slave recovery.
> 
> This is a rebased version for https://reviews.apache.org/r/29913/
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 35c7c8bf6eb8efee332c13713f6087c6f899d6e3 
>   src/slave/slave.cpp 7a29f86bf873141759957a6ef5502f6a3b6ab269 
>   src/tests/mesos.hpp 83a369968ab2403fa341829ac5d11f7243095190 
>   src/tests/mesos.cpp 21a405366f56c963611324076efe775f85b9d9f7 
>   src/tests/persistent_volume_tests.cpp e3a8d33b6ae2b6afe5f4ab7c029b2f37a861f112 
> 
> Diff: https://reviews.apache.org/r/30850/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message