mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 30609: Added os::lstatsize().
Date Tue, 10 Feb 2015 11:19:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/
-----------------------------------------------------------

(Updated Feb. 10, 2015, 3:19 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.


Changes
-------

Addressed Ian's review. Proposed name now: ownsize().


Bugs: MESOS-2072
    https://issues.apache.org/jira/browse/MESOS-2072


Repository: mesos


Description (updated)
-------

This returns a file's size as reported by lstat(). (Not stat(). It is desired that in case
of a link, the size of the link, not the size of the referenced file, is returned.)


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 8a4fda97ee29c185471a69f60803efc193cbe922

  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 8a2d445c2edaa70da0e7b50e14ef88b2d9224a16


Diff: https://reviews.apache.org/r/30609/diff/


Testing
-------

Wrote a simple test that creates a file and tests its size, and also checks if a non-existing
file yields an error.


Thanks,

Bernd Mathiske


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message