mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 29781: Exposed type_utils.hpp as include/mesos/type_utils.hpp.
Date Tue, 10 Feb 2015 02:53:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29781/
-----------------------------------------------------------

(Updated Feb. 9, 2015, 9:53 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

minor fix.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[3/9] Build Mesos Modules outside Mesos source tree.

This file includes definitions for operators on public protobufs
(defined in mesos.proto) that don't have these operators generated
by the protobuf compiler.  The corresponding definitions are in
src/common/type_utils.cpp.

Mesos modules need some of the protobufs defined in mesos.proto and
require some of these operators declared in type_utils.hpp. Exposing
type_utils.hpp allows us to build modules without having a dependency
on mesos source tree (src/*).


Diffs (updated)
-----

  src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
  src/cli/execute.cpp ea740490c133323136b58ba5771ddbe3f6e00a13 
  src/common/protobuf_utils.cpp 345d96e7b87159c997d76c18c080ed6faa07b176 
  src/common/type_utils.hpp 5c24c080f359a6adc4840f0a1586d21585616908 
  src/common/type_utils.cpp 6062e43612de92256d3ce68b9fc8427e4511bbfd 
  src/examples/low_level_scheduler_libprocess.cpp cd04187070a118739345b92418fa6682b60edb50

  src/examples/low_level_scheduler_pthread.cpp f4bd4ac1f81bb9e82e3ebb19ef2b077365a515b7 
  src/examples/no_executor_framework.cpp 5e47cfcfa1677052be114f8a9b0e24f6ef0238d9 
  src/examples/test_framework.cpp 3dfb6a04d0c473ce8fc96da7e672298fe3367053 
  src/exec/exec.cpp 38c8ee7424799727f85d9657d53845dd255cc6f3 
  src/launcher/executor.cpp 8c2f2e623b9c954735a1e6ebf965988cc861ce3c 
  src/log/coordinator.cpp 9a4383d7e502e565203026af6a3cdfbd16d79d48 
  src/log/recover.cpp 0ca737103c0e39756284ed72dadc9edfb63632f2 
  src/log/replica.cpp 2b748b3464e12ba9555b5f0e8cbbd049624657c7 
  src/master/http.cpp 138624dca30eeda2848b901c964e0a50333c8404 
  src/master/master.hpp c3c77f840f089c5754c764e7f150a3c1971d311f 
  src/master/registrar.cpp d2c5c3da3a0594676bd16dd9bb50d4c8b55afe25 
  src/master/validation.cpp 79dfaa1a8be34165331f7730dac852da02b4dcde 
  src/sched/sched.cpp ce6ff6d9adeebf398a7921421062dd5623052af1 
  src/scheduler/scheduler.cpp f5ee1b04cbc9f5fafead8a3b44769ae7d2f3487e 
  src/slave/containerizer/external_containerizer.cpp a31d66d0ed8e11c13418553b5e234f3653762c1a

  src/slave/containerizer/isolators/cgroups/cpushare.cpp 6554ca3d8c45f449ca5414c695efe813f31a101b

  src/slave/containerizer/isolators/cgroups/mem.cpp 0bb4039ba83698e663ab0527f90c46ed7bd11bf5

  src/slave/flags.hpp f6033355d129f0013d39dd053455c936596bf159 
  src/slave/http.cpp c9b573157b5faab424f82d17639de1beb7a02a96 
  src/slave/monitor.hpp 2cc42dc4da306dd8bf43bacd4a02dedd33670912 
  src/slave/paths.cpp 5102db5e3a0d86bb592d1d427ee881377aea2dbf 
  src/slave/slave.hpp 9adee17cb94a72f0e1e139b3fd8978a9a1ff6237 
  src/slave/slave.cpp 336e8776be656c5e6ad1b0d997f54c307f4559f8 
  src/slave/state.hpp 04084fc5c9130bf7d824b2ced4eb7053a995edd0 
  src/slave/status_update_manager.hpp cc53a2ab168d0f150d3d6e58e04633243607616d 
  src/tests/flags.hpp 0be991f2afa90681628ea899132e40621d158728 
  src/tests/protobuf_io_tests.cpp a54f20d49fed1dd5a740f9b9a0a48d43e79d05e0 
  src/tests/registrar_tests.cpp 3d71233f545088cf38b20f51092e3aea103e7352 
  src/tests/state_tests.cpp 4a216e6e3172b6d44087f86e030e5970450a8994 

Diff: https://reviews.apache.org/r/29781/diff/


Testing
-------

make check.


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message