mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.
Date Tue, 10 Feb 2015 00:52:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review71706
-----------------------------------------------------------

Ship it!



src/Makefile.am
<https://reviews.apache.org/r/29598/#comment117572>

    Should we contain this in it's own directory? It looks a bit inconsistent compared to
containerizer, fetcher and scheduler


- Niklas Nielsen


On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29598/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 7:15 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [1/9] Build Mesos Modules outside Mesos source tree.
> 
> To expose Modules message outside the mesos source tree.  This allows modules to #include
mesos/mesos.hpp and get the required protobuf definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b 
>   include/mesos/module.proto PRE-CREATION 
>   src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
>   src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
>   src/common/type_utils.hpp b23eeb8a4055f596aba40d0c8a8250530c870876 
>   src/master/flags.hpp e9f6fff28153212756c9d78be733ec045f291483 
>   src/messages/messages.proto 8d86517039ec825b7d2ace6673da8971e140fa5e 
>   src/slave/flags.hpp facf6d3e68e412897a1381d7bbdcceaf5d1fbb94 
> 
> Diff: https://reviews.apache.org/r/29598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message