mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 30510: Allowed Mesos containerizer to prepare and update volumes.
Date Mon, 09 Feb 2015 20:24:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30510/#review71690
-----------------------------------------------------------


tests?


src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/30510/#comment117556>

    Why pull it into the middle of 'futures' handling?



src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/30510/#comment117557>

    Why is this a CHECK? What is the guarantee that a container won't be cleaned up?



src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/30510/#comment117558>

    Add a comment here,


- Vinod Kone


On Feb. 9, 2015, 6 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30510/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 6 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-2031
>     https://issues.apache.org/jira/browse/MESOS-2031
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed Mesos containerizer to prepare and update volumes.
> 
> Mesos containerizer setup volumes for the container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d

>   src/slave/containerizer/mesos/containerizer.cpp fa40d47aee7803833bcde6cce1e86a21d7cf27d0

> 
> Diff: https://reviews.apache.org/r/30510/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message