mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 29883: Added /master/slaves endpoint.
Date Mon, 09 Feb 2015 16:34:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29883/#review71639
-----------------------------------------------------------

Ship it!



src/master/http.cpp
<https://reviews.apache.org/r/29883/#comment117507>

    I am not sure about this description.
    
    200 is expected given that this is not a conditional check (like e.g. health). Or are
we not getting a 200 in any case?
    
    How about
    
    "This endpoint receives information indicating registered slave(s)."


- Till Toenshoff


On Feb. 4, 2015, 10:37 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29883/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 10:37 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2157
>     https://issues.apache.org/jira/browse/MESOS-2157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds endpoints for paths /master/slaves.
> 
> Works in conjunction with [30612](https://reviews.apache.org/r/30612).
> 
> Builds on the abandoned patch 14286.
> 
> Old description: this is WIP that bmahler wants to take on.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 3981b18 
>   src/master/master.hpp 337e00a 
>   src/master/master.cpp 1005686 
>   src/tests/master_tests.cpp 678d27f 
> 
> Diff: https://reviews.apache.org/r/29883/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message