mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 30036: Introduced caching fields to command URI and fetcher parameter protobufs
Date Sat, 07 Feb 2015 04:19:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30036/
-----------------------------------------------------------

(Updated Feb. 6, 2015, 8:19 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.


Changes
-------

Addressed issues by added comments explaining cace flag behavior in fetcher.proto and cache
directory selection in slave/flags.hpp. Rebased.


Bugs: MESO-2069
    https://issues.apache.org/jira/browse/MESO-2069


Repository: mesos


Description
-------

Extends the CommandInfo::URI protobuf with a boolean "caching" field that will later cause
fetcher cache actions. Also introduces the notion of a cache directory to the fetcher info
protobuf. And then propagates these additions throughout the rest of the code base where applicable.
This includes passing the slave ID all the way down to the place where the cache dir name
is constructed.


Diffs (updated)
-----

  include/mesos/fetcher/fetcher.proto facb87b92bf3194516f636dcc348e136af537721 
  include/mesos/mesos.proto 3a2921dff856d37455593dcbf7340aa537997d35 
  src/launcher/fetcher.cpp 5b2d86d1867b25bf71461fd73df91b089002325b 
  src/slave/containerizer/docker.hpp 70114dcef7a416ae904e95eb9ce365bcd866aebc 
  src/slave/containerizer/docker.cpp 813ddf8c98622748b2da1b739bf122387abc4c79 
  src/slave/containerizer/fetcher.hpp bfd98dbe16e2bd5df3e2c8e9b10e303654f33446 
  src/slave/containerizer/fetcher.cpp 6e6bce08d76bb8a5813c905e3ffeff9b2411fd6d 
  src/slave/containerizer/mesos/containerizer.hpp b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d

  src/slave/containerizer/mesos/containerizer.cpp fa40d47aee7803833bcde6cce1e86a21d7cf27d0

  src/slave/flags.hpp f6033355d129f0013d39dd053455c936596bf159 
  src/tests/docker_containerizer_tests.cpp 8b212d4e6ed5a179ebadce1bdbbf3edde87d706c 
  src/tests/fetcher_tests.cpp d7266f54f77d58a997f9de794f659cfb8a565e29 

Diff: https://reviews.apache.org/r/30036/diff/


Testing
-------

make check.


Thanks,

Bernd Mathiske


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message