mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 30034: Unified fetcher testing, removed stderr/out redirection
Date Fri, 06 Feb 2015 04:51:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30034/
-----------------------------------------------------------

(Updated Feb. 5, 2015, 8:51 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-2069
    https://issues.apache.org/jira/browse/MESOS-2069


Repository: mesos


Description (updated)
-------

Makes the code structure of all fetcher tests the same. Instead of calling the run method
of the fetcher directly, calling through fetch(). Also removes all uses of I/O redirection,
which is not really needed for debugging, and thus the next patch can refactor fetch() and
run(). (The latter comes in two varieties, which complicates matters without much benefit.)


Diffs
-----

  src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7 

Diff: https://reviews.apache.org/r/30034/diff/


Testing
-------

make check


Thanks,

Bernd Mathiske


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message