mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 30601: Updated slave to use Executor/Task grace period, with a maximum.
Date Thu, 05 Feb 2015 21:33:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30601/#review71320
-----------------------------------------------------------


Bad patch!

Reviews applied: [30579, 30580]

Failed command: ./support/apply-review.sh -n -r 30580

Error:
 2015-02-05 21:33:40 URL:https://reviews.apache.org/r/30580/diff/raw/ [14158/14158] ->
"30580.patch" [1]
error: patch failed: src/tests/slave_tests.cpp:1683
error: src/tests/slave_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Feb. 5, 2015, 9:02 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30601/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 9:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2228
>     https://issues.apache.org/jira/browse/MESOS-2228
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now the slave doesn't completely ignore the grace period, note that there is a bound
of 1 minute for now.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 28612168c66d85679b35d743e96954770f37daec 
>   src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 
>   src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6 
>   src/slave/containerizer/containerizer.cpp 421bb868b353e644578fa27f04bdd636bfc89134

>   src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b 
>   src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 
> 
> Diff: https://reviews.apache.org/r/30601/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message