mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 30036: Introduced caching fields to command URI and fetcher parameter protobufs
Date Thu, 05 Feb 2015 16:32:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30036/#review71228
-----------------------------------------------------------

Ship it!



include/mesos/mesos.proto
<https://reviews.apache.org/r/30036/#comment116899>

    Can we add a small comment about semantics here? Specifically, if we've already cached
and then run another command without 'cache' what will happen? Also, can we s/caching/cache/
to show the action?



src/slave/flags.hpp
<https://reviews.apache.org/r/30036/#comment116900>

    Lets explain why we aren't nesting this in the work directory, i.e., it's not an automatic
flag: (1) it's probably not meant to be backed up (that's a lot of data to back up) and (2)
you might want to put it on a different disk.


- Benjamin Hindman


On Jan. 25, 2015, 11:27 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30036/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2015, 11:27 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESO-2069
>     https://issues.apache.org/jira/browse/MESO-2069
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extends the CommandInfo::URI protobuf with a boolean "caching" field that will later
cause fetcher cache actions. Also introduces the notion of a cache directory to the fetcher
info protobuf. And then propagates these additions throughout the rest of the code base where
applicable. This includes passing the slave ID all the way down to the place where the cache
dir name is constructed.
> 
> 
> Diffs
> -----
> 
>   include/mesos/fetcher/fetcher.proto facb87b92bf3194516f636dcc348e136af537721 
>   include/mesos/mesos.proto 26003fada2e4c4be0e9ebc4663f7ebab858cc48d 
>   src/launcher/fetcher.cpp fed0105946da579a38357a30e7ae56e646e05b89 
>   src/slave/containerizer/docker.hpp b7bf54ac65d6c61622e485ac253513eaac2e4f88 
>   src/slave/containerizer/docker.cpp 5f4b4ce49a9523e4743e5c79da4050e6f9e29ed7 
>   src/slave/containerizer/fetcher.hpp 1db0eaf002c8d0eaf4e0391858e61e0912b35829 
>   src/slave/containerizer/fetcher.cpp d290f95251def3952c5ee34f600e1d71467f6293 
>   src/slave/containerizer/mesos/containerizer.hpp 802988c90ac872b0cefa5e28f06e6fec98e8d032

>   src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0

>   src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f 
>   src/tests/docker_containerizer_tests.cpp 2105ae2c410f01e7e0d10241d5c00df143fd3439 
>   src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7 
> 
> Diff: https://reviews.apache.org/r/30036/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message