mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 28809: Started to maintain and checkpoint persisted resource in slave.
Date Thu, 05 Feb 2015 01:11:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28809/#review71111
-----------------------------------------------------------


tests?


src/slave/slave.cpp
<https://reviews.apache.org/r/28809/#comment116715>

    s/and/or/



src/slave/slave.cpp
<https://reviews.apache.org/r/28809/#comment116713>

    the fact that a failed slave will restart is dependent on the cluster operator right?
how about 
    
    "..we simply fail the slave to be safe."



src/slave/slave.cpp
<https://reviews.apache.org/r/28809/#comment116718>

    s/from/for/



src/slave/slave.cpp
<https://reviews.apache.org/r/28809/#comment116721>

    s/from/for/



src/slave/slave.cpp
<https://reviews.apache.org/r/28809/#comment116709>

    Can you also expand on the implications of out-of-order messages? Does the master reconcile
them? I guess if master fails over we cannot reconcile. Do we expect Frameworks to reconcile
in this case based on the offers they get?


- Vinod Kone


On Feb. 4, 2015, 7:13 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28809/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 7:13 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2031
>     https://issues.apache.org/jira/browse/MESOS-2031
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Started to maintain and checkpoint persisted resource in slave. That includes:
> 1) responds to update resources message
> 2) checkpoint resources
> 3) recover checkpointed resources
> 4) send checkpointed resources during register/reregister
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 
>   src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b 
> 
> Diff: https://reviews.apache.org/r/28809/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message