mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 27531: Update Master metrics to match task source and reason scheme.
Date Thu, 05 Feb 2015 00:20:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71080
-----------------------------------------------------------



src/master/master.cpp
<https://reviews.apache.org/r/27531/#comment116668>

    it's an enum. the copy is really a noop.



src/tests/master_authorization_tests.cpp
<https://reviews.apache.org/r/27531/#comment116674>

    there's a ticket somewhere about introducing metrics into all the existing tests instead
of having to duplicate the logic in metric-specific tests.
    
    given the code here already triggers these metrics, it seemed reasonable to test them.
    
    the alternative is adding tests in master_tests that do the same as this test (ie, remove
slaves, lose tasks) but for every combination of reason/source.
    
    neither seems ideal.



src/tests/mesos.hpp
<https://reviews.apache.org/r/27531/#comment116677>

    added TODO to kill it from rate_limiting_tests.


- Dominic Hamon


On Feb. 4, 2015, 4:19 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27531/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 4:19 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1830
>     https://issues.apache.org/jira/browse/MESOS-1830
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update metrics in Master to match the source and reason split for task statuses.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp f4b6463b4af967afc2ff78862687cddc8617962b 
>   src/master/metrics.hpp 6a43abc914dce24c60b5db57ee01d172c8258e82 
>   src/master/metrics.cpp 956fe5042d7478d90d4f03059e248694ba2b95e5 
>   src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 
>   src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b 
>   src/tests/master_authorization_tests.cpp 20adaa954a0ddfe3459d8a3f9696b5ca9ae07f24 
>   src/tests/master_slave_reconciliation_tests.cpp 04806ede4e727fa4de1464017a06797d69b54e29

>   src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed 
>   src/tests/mesos.hpp 17c2d8f0cb6326b08fc506143e823ee2c3a32e09 
>   src/tests/mesos.cpp 5ed4df530cf1bf11eec3b29542641822e0f702b2 
>   src/tests/rate_limiting_tests.cpp 7f5ca251fef5b1852bb273505f5eaed750578b9f 
>   src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 
> 
> Diff: https://reviews.apache.org/r/27531/diff/
> 
> 
> Testing
> -------
> 
> added metric tests to master tests
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message