mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 30386: Added support for CREATE operation in master.
Date Wed, 04 Feb 2015 20:56:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30386/#review71040
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/30386/#comment116562>

    Maybe we should add a little note there that there is no direct feedback to the framework
when an operation is dropped, they will find out that the operation was dropped through subsequent
offers.



src/master/master.cpp
<https://reviews.apache.org/r/30386/#comment116565>

    Why not use `drop` for these?



src/master/master.cpp
<https://reviews.apache.org/r/30386/#comment116566>

    Use `drop`?



src/master/master.cpp
<https://reviews.apache.org/r/30386/#comment116563>

    Are you planning to keep this variable? Seems like every operation will require checkpointing
for now, hence the name of the method being `updateCheckpointedResource`? :)



src/master/master.cpp
<https://reviews.apache.org/r/30386/#comment116567>

    Hm.. seems like this method should enforce that the operation type is supported (via CHECK
or LOG(FATAL))? The caller is expected not to call this with anything that might get dropped
in here, right?


- Ben Mahler


On Feb. 4, 2015, 1:09 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30386/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 1:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for CREATE operation in master.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp cd37ee9d3c57bcd91f08cd402ec1e4a09d9e42ee 
>   src/master/master.cpp d04b2c4041d8fe8978b877f07579a6f907903e1b 
> 
> Diff: https://reviews.apache.org/r/30386/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message