mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 30635: Fixed MESOS-2319 by creating the temporary file under the same base directory.
Date Wed, 04 Feb 2015 20:40:00 GMT


> On Feb. 4, 2015, 8:31 p.m., Ben Mahler wrote:
> > Is there a test of this function?
> > 
> > Might be nice to add a NOTE or TODO about how to address the issue of leaving dangling
files when we failover at the wrong time?

Yes, SlaveStateTest should catch the regression.

Will add a NOTE, the dangline file will most likely be GCed with the directory since we cannot
recover the task/executor.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30635/#review71035
-----------------------------------------------------------


On Feb. 4, 2015, 7:38 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30635/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 7:38 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-2319
>     https://issues.apache.org/jira/browse/MESOS-2319
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed MESOS-2319 by creating the temporary file under the same base directory.
> 
> 
> Diffs
> -----
> 
>   src/slave/state.hpp de631fb2c8a8d2bcbb861c438b18141ba6211024 
> 
> Diff: https://reviews.apache.org/r/30635/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message