mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 30074: Added "max allowed age" to Slave stats.json endpoint
Date Wed, 04 Feb 2015 15:39:14 GMT


> On Jan. 28, 2015, 7:17 p.m., Niklas Nielsen wrote:
> > src/slave/http.cpp, lines 273-276
> > <https://reviews.apache.org/r/30074/diff/3/?file=828308#file828308line273>
> >
> >     Why stats and not state.json?

sorry, my bad.


> On Jan. 28, 2015, 7:17 p.m., Niklas Nielsen wrote:
> > src/slave/http.cpp, line 274
> > <https://reviews.apache.org/r/30074/diff/3/?file=828308#file828308line274>
> >
> >     We should think about how to get the fact in, that it integer is a number of
seconds.
> >     
> >     How about something like:
> >     
> >     max_allowed_directory_age_seconds = 42
> >     or
> >     max_allowed_directory_seconds = 42
> >     
> >     ?

Yeah, I was wondering about that too, I like that idea too. Too keep it consistant with https://github.com/apache/mesos/blob/master/src/slave/metrics.cpp#L35
I will use the `_secs` prefix


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30074/#review70029
-----------------------------------------------------------


On Jan. 21, 2015, 2:55 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30074/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 2:55 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
> 
> 
> Bugs: mesos-2229
>     https://issues.apache.org/jira/browse/mesos-2229
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds and entry `max_allowed_age` to the response of the stats.json endpoint in the slave.
The format of the value is `{double}(days|mins|secs)`.
> 
> The max allowed age value is available only if it is set, which depends on the flag `--disk_watch_interval`
which by default runs every minute (So it will only be available after the first minute running).
> 
> Modifies the unit test `SlaveTest.MetricsInStatsEndpoint` so it takes into account the
new entry.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp d1cf8a6 
>   src/slave/slave.hpp 70bd8c1 
>   src/slave/slave.cpp fca83b3 
>   src/tests/slave_tests.cpp a85a028 
> 
> Diff: https://reviews.apache.org/r/30074/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message