mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 30606: Added net::contentLength() to query "content-length" field from HTTP header.
Date Wed, 04 Feb 2015 06:50:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30606/#review70931
-----------------------------------------------------------


Patch looks great!

Reviews applied: [30606]

All tests passed.

- Mesos ReviewBot


On Feb. 4, 2015, 6:03 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30606/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 6:03 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2072
>     https://issues.apache.org/jira/browse/MESOS-2072
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds net::contentLength(). This makes a short HTTP request to read the "content-length"
field from the HTTP header.
> 
> This will be used to determine the size of a file before downloading it to the fetcher
cache, in order to ensure there is enough space ahead of time.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a0210ea 
> 
> Diff: https://reviews.apache.org/r/30606/diff/
> 
> 
> Testing
> -------
> 
> Used this function in the context of my implementation of MESOS-2072 and MESOS-2074.
It correctly reported the content length from an HTTP server constructed from libprocess primitives.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message