mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 29742: Added useful utility functions to determine types of resources.
Date Tue, 03 Feb 2015 23:05:23 GMT


> On Feb. 3, 2015, 8:19 p.m., Vinod Kone wrote:
> > include/mesos/resources.hpp, line 92
> > <https://reviews.apache.org/r/29742/diff/4/?file=839661#file839661line92>
> >
> >     We didn't do "isempty" above, so how about getting rid of "is" as prefix? I
think returning a "bool" signals a "is".

Hm, that's a good point. I'll fix that.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/#review70817
-----------------------------------------------------------


On Jan. 29, 2015, 5:27 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29742/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 5:27 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A few boolean functions to test the state of the `Resource` object.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 3b57568c10233a0c692787de6464f21af5eaadf4 
>   src/common/resources.cpp 68f64213c47be4700bcb22cd5b76ba6ff616960d 
> 
> Diff: https://reviews.apache.org/r/29742/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message