mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 30218: Add version() to docker abstraction.
Date Mon, 02 Feb 2015 17:15:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30218/#review70583
-----------------------------------------------------------



src/docker/docker.cpp
<https://reviews.apache.org/r/30218/#comment115794>

    Why do we not limit the wait time here any more? Is it guaranteed to be short if the subprocess
has terminated? Also, why remove the error reporting? Are these error conditions expected
to never occur? Potential error messages from read() alone are not specific to this code here.


- Bernd Mathiske


On Jan. 23, 2015, 9:44 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30218/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 9:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add version() to docker abstraction.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 3ebbc1f 
>   src/docker/docker.cpp 3a485a2 
> 
> Diff: https://reviews.apache.org/r/30218/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message