Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D916617AB8 for ; Fri, 30 Jan 2015 00:42:32 +0000 (UTC) Received: (qmail 66212 invoked by uid 500); 30 Jan 2015 00:42:33 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 66139 invoked by uid 500); 30 Jan 2015 00:42:33 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 66126 invoked by uid 99); 30 Jan 2015 00:42:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jan 2015 00:42:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 324E41D99BB; Fri, 30 Jan 2015 00:42:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2246390071021724738==" MIME-Version: 1.0 Subject: Re: Review Request 30423: Fixed the flaky FaultToleranceTest.eSchedulerFailoverFrameworkMessage test. From: "Vinod Kone" To: "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Fri, 30 Jan 2015 00:42:28 -0000 Message-ID: <20150130004228.25679.32116@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/30423/ X-Sender: "Vinod Kone" References: <20150129195419.25680.69687@reviews.apache.org> In-Reply-To: <20150129195419.25680.69687@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos-git --===============2246390071021724738== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30423/#review70297 ----------------------------------------------------------- Ship it! src/tests/fault_tolerance_tests.cpp I think this could be moved up, right after driver2.start() ? - Vinod Kone On Jan. 29, 2015, 7:54 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30423/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 7:54 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2302 > https://issues.apache.org/jira/browse/MESOS-2302 > > > Repository: mesos-git > > > Description > ------- > > From MESOS-2302: > > Comparing the runs, you can see that there's a race in which the driver gets stopped before the error reaches it: > > Bad run: > ``` > I0123 18:50:12.034864 15688 sched.cpp:1471] Asked to stop the driver > ... > I0123 18:50:12.037359 15710 sched.cpp:788] Ignoring error message because the driver is not running! > ``` > > Good run: > ``` > I0122 19:15:01.721943 3540 sched.cpp:792] Got error 'Framework failed over' > I0122 19:15:01.721972 3540 sched.cpp:1505] Asked to abort the driver > I0122 19:15:01.722039 3540 sched.cpp:803] Scheduler::error took 26469ns > ... > I0122 19:15:01.727665 3518 sched.cpp:1471] Asked to stop the driver > ``` > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp e0065b3a89b9af27c5584bcfdd8c790814bf1af6 > > Diff: https://reviews.apache.org/r/30423/diff/ > > > Testing > ------- > > 100 repetitions of this test > > > Thanks, > > Ben Mahler > > --===============2246390071021724738==--