Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B32F1730C for ; Thu, 22 Jan 2015 22:26:52 +0000 (UTC) Received: (qmail 40107 invoked by uid 500); 22 Jan 2015 22:26:52 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 40030 invoked by uid 500); 22 Jan 2015 22:26:52 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 40005 invoked by uid 99); 22 Jan 2015 22:26:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jan 2015 22:26:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 22A151D5CAA; Thu, 22 Jan 2015 22:26:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7272391328319550969==" MIME-Version: 1.0 Subject: Re: Review Request 30192: Updated RateLimiter to allow discard semantics. From: "Dominic Hamon" To: "Ben Mahler" , "Jie Yu" Cc: "Dominic Hamon" , "mesos" , "Vinod Kone" Date: Thu, 22 Jan 2015 22:26:48 -0000 Message-ID: <20150122222648.9402.19166@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dominic Hamon" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/30192/ X-Sender: "Dominic Hamon" References: <20150122222409.9401.68603@reviews.apache.org> In-Reply-To: <20150122222409.9401.68603@reviews.apache.org> Reply-To: "Dominic Hamon" X-ReviewRequest-Repository: mesos-git --===============7272391328319550969== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30192/#review69284 ----------------------------------------------------------- 3rdparty/libprocess/include/process/limiter.hpp a scoped pointer would be perfect here, don't you think? ;) - Dominic Hamon On Jan. 22, 2015, 2:24 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30192/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 2:24 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-2230 > https://issues.apache.org/jira/browse/MESOS-2230 > > > Repository: mesos-git > > > Description > ------- > > I tried/implemented a complex solution involving list iterators and removing discarded promises from the list, but it was hard to reason about the correctness and race conditions. So abandoned it in favor of a simpler solution. Let me know what you think. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/limiter.hpp a1c4f189565003f19f8b33c3b8a81e28836069c1 > 3rdparty/libprocess/src/tests/limiter_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30192/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > > --===============7272391328319550969==--