Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============3107963193410574275=="
MIME-Version: 1.0
Subject: Review Request 29569: Refactored Once abstraction to not use Promise.
From: "Benjamin Hindman" <benh@berkeley.edu>
To: "Joris Van Remoortere" <joris.van.remoortere@gmail.com>,
 "Niklas Nielsen" <nik@qni.dk>
Cc: "mesos" <dev@mesos.apache.org>, "Benjamin Hindman" <benh@berkeley.edu>
Date: Wed, 21 Jan 2015 17:54:36 -0000
Message-ID: <20150121175436.9402.80582@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Benjamin Hindman" <noreply@reviews.apache.org>
Reply-To: "Benjamin Hindman" <benh@berkeley.edu>

--===============3107963193410574275==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29569/
-----------------------------------------------------------

Review request for mesos, Joris Van Remoortere and Niklas Nielsen.


Repository: mesos-git


Description
-------

The original once abstraction was implemented using promises, which made it unusable to initialize libprocess because libprocess must be initialized in order to use a Promise. This removes that requirement, but it also means that an actor blocking on a Once will no longer donate it's thread while it's waiting (since it doesn't wait on a Promise, which waits on a Latch, which waits on a ProcessBase, which donates the thread while waiting).


Diffs
-----

  3rdparty/libprocess/include/process/once.hpp e85b38205065b34d438f68a6441905eb2f90169c 

Diff: https://reviews.apache.org/r/29569/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


--===============3107963193410574275==--