Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 371E51096C for ; Wed, 21 Jan 2015 11:24:28 +0000 (UTC) Received: (qmail 4219 invoked by uid 500); 21 Jan 2015 11:24:28 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 4150 invoked by uid 500); 21 Jan 2015 11:24:27 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 4127 invoked by uid 99); 21 Jan 2015 11:24:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jan 2015 11:24:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EAD7A1CA91D; Wed, 21 Jan 2015 11:24:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3282368111639072371==" MIME-Version: 1.0 Subject: Re: Review Request 30006: Enabled concurrent downloading into the fetcher cache From: "Bernd Mathiske" To: "Benjamin Hindman" , "Adam B" , "Timothy Chen" Cc: "Bernd Mathiske" , "mesos" Date: Wed, 21 Jan 2015 11:24:23 -0000 Message-ID: <20150121112423.9402.34632@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bernd Mathiske" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/30006/ X-Sender: "Bernd Mathiske" References: <20150121104948.9401.64368@reviews.apache.org> In-Reply-To: <20150121104948.9401.64368@reviews.apache.org> Reply-To: "Bernd Mathiske" X-ReviewRequest-Repository: mesos-git --===============3282368111639072371== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30006/#review68896 ----------------------------------------------------------- src/slave/containerizer/fetcher.hpp 4 spaces src/slave/containerizer/fetcher.hpp 4 spaces - Bernd Mathiske On Jan. 21, 2015, 2:49 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30006/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 2:49 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Timothy Chen. > > > Bugs: MESOS-2057 > https://issues.apache.org/jira/browse/MESOS-2057 > > > Repository: mesos-git > > > Description > ------- > > Enables reuse of download results in the cache when multiple fetcher runs occur concurrently. Optimizes for minimal number of fetcher runs, between 0 and 2, depending on what is in the cache and what can be obtained from concurrent runs by simply waiting for their already initiated downloads for the same content to complete. > > > Diffs > ----- > > src/slave/containerizer/fetcher.hpp 1db0eaf002c8d0eaf4e0391858e61e0912b35829 > src/slave/containerizer/fetcher.cpp 5993670f7899233efa1e6acef4b0c7856e32f748 > > Diff: https://reviews.apache.org/r/30006/diff/ > > > Testing > ------- > > make check, testing whether legacy direct fetching still works, using existing tests. > > Testing of cache functionality coming in MESOS-2074. > > > Thanks, > > Bernd Mathiske > > --===============3282368111639072371==--