Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3841710CD1 for ; Mon, 19 Jan 2015 22:52:08 +0000 (UTC) Received: (qmail 18912 invoked by uid 500); 19 Jan 2015 22:52:10 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 18840 invoked by uid 500); 19 Jan 2015 22:52:10 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 18817 invoked by uid 99); 19 Jan 2015 22:52:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Jan 2015 22:52:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0ADB61D2C48; Mon, 19 Jan 2015 22:52:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3262803544668439321==" MIME-Version: 1.0 Subject: Re: Review Request 29597: Removed #include slave/flags.hpp from isolator.hpp From: "Kapil Arya" To: "Niklas Nielsen" , "Till Toenshoff" , "Timothy Chen" Cc: "mesos" , "Kapil Arya" Date: Mon, 19 Jan 2015 22:52:06 -0000 Message-ID: <20150119225206.9401.23574@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/29597/ X-Sender: "Kapil Arya" References: <20150113164240.23996.59023@reviews.apache.org> In-Reply-To: <20150113164240.23996.59023@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos-git --===============3262803544668439321== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29597/ ----------------------------------------------------------- (Updated Jan. 19, 2015, 5:52 p.m.) Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. Changes ------- Rebased diff. Repository: mesos-git Description ------- Slave flags are not being used in isolator.hpp. Removed #include slave/flags.hpp from isolator.hpp and included it directly in only those files that need it. Diffs (updated) ----- src/slave/containerizer/isolator.hpp a27c3e955ff25b87599af0ac2c97427a88b786f6 src/slave/containerizer/isolators/cgroups/cpushare.hpp 4ded0c4678ad61742a69e14233006a448f3fc3ca src/slave/containerizer/isolators/cgroups/mem.hpp 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6 src/slave/containerizer/isolators/cgroups/perf_event.hpp e511c3efe4cc4ec13cc74bdcda993477a4db2e36 src/slave/containerizer/isolators/filesystem/shared.hpp 727f63e16fa69293c472a4b6b95fb0be04e689c8 src/slave/containerizer/isolators/namespaces/pid.hpp 8da6cccff04edf11fa37f5a33648821299cf49d5 src/slave/containerizer/isolators/posix.hpp 7a667e3e30712b98484947520b58965d3b768659 src/slave/containerizer/isolators/posix/disk.hpp cf4e143eb50cf5ee59ca0d47dd6f8d0a845c3732 Diff: https://reviews.apache.org/r/29597/diff/ Testing ------- make check Thanks, Kapil Arya --===============3262803544668439321==--