Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 74363176D1 for ; Fri, 9 Jan 2015 23:06:07 +0000 (UTC) Received: (qmail 33159 invoked by uid 500); 9 Jan 2015 23:06:08 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 33092 invoked by uid 500); 9 Jan 2015 23:06:08 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 33020 invoked by uid 99); 9 Jan 2015 23:06:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jan 2015 23:06:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D814C1D0D70; Fri, 9 Jan 2015 23:06:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1396227269219574676==" MIME-Version: 1.0 Subject: Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building. From: "Kapil Arya" To: "Niklas Nielsen" , "Till Toenshoff" , "Timothy Chen" Cc: "mesos" , "Kapil Arya" Date: Fri, 09 Jan 2015 23:06:05 -0000 Message-ID: <20150109230605.26559.33106@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/29604/ X-Sender: "Kapil Arya" References: <20150106223920.26560.7942@reviews.apache.org> In-Reply-To: <20150106223920.26560.7942@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos-git --===============1396227269219574676== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29604/ ----------------------------------------------------------- (Updated Jan. 9, 2015, 6:06 p.m.) Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. Changes ------- rebased diff. Bugs: MESOS-2096 https://issues.apache.org/jira/browse/MESOS-2096 Repository: mesos-git Description (updated) ------- [8/10] Build Mesos Modules outside Mesos source tree. The isolation module can thus include to get all required definitions. Diffs (updated) ----- src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 src/slave/containerizer/mesos/containerizer.cpp 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc Diff: https://reviews.apache.org/r/29604/diff/ Testing ------- make check Thanks, Kapil Arya --===============1396227269219574676==--