Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 39C931799A for ; Tue, 6 Jan 2015 00:45:14 +0000 (UTC) Received: (qmail 45446 invoked by uid 500); 6 Jan 2015 00:45:15 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 45396 invoked by uid 500); 6 Jan 2015 00:45:15 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 45368 invoked by uid 99); 6 Jan 2015 00:45:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jan 2015 00:45:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E162F1CABF7; Tue, 6 Jan 2015 00:45:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8877749708907235742==" MIME-Version: 1.0 Subject: Re: Review Request 29380: Added resource transformations to the launchTasks API. From: "Jie Yu" To: "switched to 'mcypark'" , "Benjamin Hindman" , "Adam B" , "Ben Mahler" , "Vinod Kone" Cc: "mesos" , "Jie Yu" , "Mesos ReviewBot" Date: Tue, 06 Jan 2015 00:45:10 -0000 Message-ID: <20150106004510.26559.53925@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/29380/ X-Sender: "Jie Yu" References: <20141223220436.10621.19375@reviews.apache.org> In-Reply-To: <20141223220436.10621.19375@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos-git --===============8877749708907235742== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29380/ ----------------------------------------------------------- (Updated Jan. 6, 2015, 12:45 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to 'mcypark', and Vinod Kone. Changes ------- Haven't addressed the review comments yet. Try to unblock mpark. Summary (updated) ----------------- Added resource transformations to the launchTasks API. Repository: mesos-git Description ------- Added resource operations to the launchTasks API. See details in https://reviews.apache.org/r/29173/ The reason for introducing resource operations while launching task is to allow frameworks to transform the offered resources for persistent disk and dynamic reservation. We want the framework to explicitly set them so that it causes less confusion to the master (master no long needs to infer resource transformations which sometimes are ambiguate). Diffs (updated) ----- include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e include/mesos/scheduler/scheduler.proto 5491c59e7addda0ee5d95a019d7eaeb953ca82e4 src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887 src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1 src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e Diff: https://reviews.apache.org/r/29380/diff/ Testing ------- make check Thanks, Jie Yu --===============8877749708907235742==--