Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E7685177CE for ; Tue, 6 Jan 2015 00:01:50 +0000 (UTC) Received: (qmail 25536 invoked by uid 500); 6 Jan 2015 00:01:51 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 25467 invoked by uid 500); 6 Jan 2015 00:01:51 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 25072 invoked by uid 99); 6 Jan 2015 00:01:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jan 2015 00:01:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1DD5A1CABF7; Tue, 6 Jan 2015 00:01:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6308076692862713046==" MIME-Version: 1.0 Subject: Re: Review Request 29033: PortMappingIsolator: added metrics for the numbers of active and TIME_WAIT tcp connections. From: "Chi Zhang" To: "Dominic Hamon" , "Jie Yu" , "Ian Downes" , "Cong Wang" Cc: "mesos" , "Chi Zhang" , "Mesos ReviewBot" Date: Tue, 06 Jan 2015 00:01:48 -0000 Message-ID: <20150106000148.26560.26605@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chi Zhang" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/29033/ X-Sender: "Chi Zhang" References: <20150105205112.26559.58349@reviews.apache.org> In-Reply-To: <20150105205112.26559.58349@reviews.apache.org> Reply-To: "Chi Zhang" X-ReviewRequest-Repository: mesos-git --===============6308076692862713046== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29033/ ----------------------------------------------------------- (Updated Jan. 6, 2015, 12:01 a.m.) Review request for mesos, Dominic Hamon, Ian Downes, Jie Yu, and Cong Wang. Changes ------- addressed comments. Repository: mesos-git Description ------- While we are still working to make RTT less expensive to get, expose total number of tcp connections in use and in TIME_WAIT. Diffs (updated) ----- include/mesos/mesos.proto 540071d src/slave/containerizer/isolators/network/port_mapping.hpp f1e2352 src/slave/containerizer/isolators/network/port_mapping.cpp 2d81336 src/slave/flags.hpp 670997d src/tests/port_mapping_tests.cpp eb82993 Diff: https://reviews.apache.org/r/29033/diff/ Testing ------- expanded a test case to test PortMappingStatistics. Thanks, Chi Zhang --===============6308076692862713046==--