mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 30423: Fixed the flaky FaultToleranceTest.eSchedulerFailoverFrameworkMessage test.
Date Thu, 29 Jan 2015 20:55:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30423/#review70272
-----------------------------------------------------------


Patch looks great!

Reviews applied: [30423]

All tests passed.

- Mesos ReviewBot


On Jan. 29, 2015, 7:54 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30423/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 7:54 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2302
>     https://issues.apache.org/jira/browse/MESOS-2302
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> From MESOS-2302:
> 
> Comparing the runs, you can see that there's a race in which the driver gets stopped
before the error reaches it:
> 
> Bad run:
> ```
> I0123 18:50:12.034864 15688 sched.cpp:1471] Asked to stop the driver
> ...
> I0123 18:50:12.037359 15710 sched.cpp:788] Ignoring error message because the driver
is not running!
> ```
> 
> Good run:
> ```
> I0122 19:15:01.721943  3540 sched.cpp:792] Got error 'Framework failed over'
> I0122 19:15:01.721972  3540 sched.cpp:1505] Asked to abort the driver
> I0122 19:15:01.722039  3540 sched.cpp:803] Scheduler::error took 26469ns
> ...
> I0122 19:15:01.727665  3518 sched.cpp:1471] Asked to stop the driver
> ```
> 
> 
> Diffs
> -----
> 
>   src/tests/fault_tolerance_tests.cpp e0065b3a89b9af27c5584bcfdd8c790814bf1af6 
> 
> Diff: https://reviews.apache.org/r/30423/diff/
> 
> 
> Testing
> -------
> 
> 100 repetitions of this test
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message