mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 29927: Implemented MasterAllocatorTest::StopAllocator() method.
Date Thu, 29 Jan 2015 01:38:39 GMT


> On Jan. 27, 2015, 7:55 p.m., Ben Mahler wrote:
> > src/tests/master_allocator_tests.cpp, lines 80-81
> > <https://reviews.apache.org/r/29927/diff/3/?file=836337#file836337line80>
> >
> >     Can we be very explicit here about why we need this, and what is causing the
flakiness? How does this relate to my patches to silence the mock warnings?
> 
> Alexander Rukletsov wrote:
>     The ticket https://issues.apache.org/jira/browse/MESOS-1677 is a bit misleading:
it says the test is flaky but shows just a GMOCK warning in the log. I tried to reproduce
"flakiness" without stopping allocator explicitly, but without success. Let's keep refactor
and this issue separate. I suggest we keep this patch since it restores status quo, reopen
MESOS-1677 and remove this code afterwards if the issue won't be confirmed. Thoughts?

> I suggest we keep this patch since it restores status quo

Hm.. am I correct in understanding that this patch corrects MESOS-1677? If not, what is the
status quo that this restores? Note that my mock warning fix is committed.

I'm still a bit confused as to why you want this, given the WARNING fix. :)


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927/#review69870
-----------------------------------------------------------


On Jan. 28, 2015, 5:29 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29927/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2015, 5:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2213
>     https://issues.apache.org/jira/browse/MESOS-2213
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Several tests have been reported flaky if allocation is not ceased explicitly (see MESOS-1677).
To stop allocation, an allocator instance should be destroyed. To facilitate this, store a
pointer to a MockAllocator instance in the MasterAllocatorTest fixture and let a test case
destroy it.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_allocator_tests.cpp 2430622 
> 
> Diff: https://reviews.apache.org/r/29927/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu, OS X)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message