mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 30348: Clear all callbacks when a future is completed.
Date Wed, 28 Jan 2015 22:37:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30348/#review70100
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/include/process/future.hpp
<https://reviews.apache.org/r/30348/#comment115078>

    Any reason to have these comments?
    
    We added internal::run to make it obvious that we're running the callbacks, these comments
seem to not add any insight :)
    
    Ditto above.


- Ben Mahler


On Jan. 28, 2015, 10 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30348/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2015, 10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu.
> 
> 
> Bugs: MESOS-2279
>     https://issues.apache.org/jira/browse/MESOS-2279
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is important so that the callbacks of a future can hold a reference to the same
future. If we don't clear the callback, the future will never get gc'ed. See bug for details.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 0326b23cdd475c6e86b33f9b4c63136fdecab443

> 
> Diff: https://reviews.apache.org/r/30348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message