mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 29290: Created IP address abstraction for different protocol families
Date Wed, 28 Jan 2015 22:04:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------

(Updated Jan. 28, 2015, 10:04 p.m.)


Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and
Niklas Nielsen.


Bugs: MESOS-1919
    https://issues.apache.org/jira/browse/MESOS-1919


Repository: mesos-git


Description
-------

Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but
write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing
of the protocol headers differ.


Diffs (updated)
-----

  src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1 
  src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553 
  src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff 
  src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d 
  src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2 
  src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d 
  src/master/http.cpp 3981b18cb82d3b8bd974b80d27f14c304898a43c 
  src/master/master.cpp 54f26900ac8c63e79a1f89562a988c9a2567d209 
  src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2 
  src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268 
  src/slave/containerizer/isolators/network/port_mapping.cpp b484bbf34060ccc9debd48a3e840c03c8f95de09

  src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b 
  src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de 
  src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed 
  src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101 
  src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23 

Diff: https://reviews.apache.org/r/29290/diff/


Testing
-------

make check


Thanks,

Evelina Dumitrescu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message