mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 30283: Separated offer operations in Master::_accept
Date Wed, 28 Jan 2015 22:00:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30283/#review70090
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/30283/#comment115056>

    Looks like there's no space at the end. We should also probably print the string in these
cases where we know the type.
    
    ```
    "Unsupported offer operation: '" << Offer::Operation::Type_Name(operation.type())
<< "'";
    ```


- Ben Mahler


On Jan. 26, 2015, 8:30 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30283/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 8:30 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Michael Park.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> To avoid potential conflicts.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f 
> 
> Diff: https://reviews.apache.org/r/30283/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message