mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 29289: libprocess: Created IP address abstraction for different protocol families
Date Wed, 28 Jan 2015 21:58:36 GMT


> On Jan. 27, 2015, 3:41 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, lines 127-129
> > <https://reviews.apache.org/r/29289/diff/9/?file=834358#file834358line127>
> >
> >     Would it make sense to provide a constructor in net::IP::InAddrStorage that
takes family, or an enum and default constructs correctly? This seems like a repetitive, error
prone pattern right now.

added a static fcatory method fromFamily.


- Evelina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review69741
-----------------------------------------------------------


On Jan. 28, 2015, 9:57 p.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2015, 9:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere,
and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1919
>     https://issues.apache.org/jira/browse/MESOS-1919
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6
field.
> I intend to use the same Classifiers, addition, removal and update of container filters,
but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing
of the protocol headers differ.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af

>   3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22

>   3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e

>   3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 
>   3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d 
>   3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf 
>   3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f 
> 
> Diff: https://reviews.apache.org/r/29289/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message