mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 30353: Fixed a race in Cluster shutdown when destroying containers.
Date Wed, 28 Jan 2015 05:27:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30353/#review69960
-----------------------------------------------------------

Ship it!


Ship It!

- Bernd Mathiske


On Jan. 27, 2015, 7:06 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30353/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Vinod Kone.
> 
> 
> Bugs: MESOS-2283
>     https://issues.apache.org/jira/browse/MESOS-2283
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> There was a race in the cluster shutdown code: after we obtain the set of containers
and before call 'wait' on each one, some containers may terminate, which leads to a 'wait'
failure.
> 
> This fixes the flaky SlaveRecoveryTest.ReconcileKillTask test in MESOS-2283.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.hpp 74cedb324949143fd1949082d8a4db596a32d95c 
> 
> Diff: https://reviews.apache.org/r/30353/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message