mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 29288: stout: Created IP address abstraction for different protocol families
Date Tue, 27 Jan 2015 20:14:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/#review69856
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/29288/#comment114667>

    Missing period.



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/29288/#comment114668>

    Fix indentation.



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/29288/#comment114669>

    Might be worth pulling this out as a constant?



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/29288/#comment114670>

    can we change this to
    `const std::string hostname(result->ai_canonname);'



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/29288/#comment114671>

    should this be a switch statement that errors on the default case as above?



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/29288/#comment114693>

    should we convert this to a switch to be consistent?



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/29288/#comment114694>

    Switch statement to be consistent?



3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp
<https://reviews.apache.org/r/29288/#comment114695>

    Can you check the indentation on this?



3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp
<https://reviews.apache.org/r/29288/#comment114696>

    indentation.



3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp
<https://reviews.apache.org/r/29288/#comment114697>

    Indentation.



3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp
<https://reviews.apache.org/r/29288/#comment114698>

    Can you check the indentation here?


- Joris Van Remoortere


On Jan. 27, 2015, 4:58 p.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29288/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 4:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere,
and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1919
>     https://issues.apache.org/jira/browse/MESOS-1919
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6
field.
> I intend to use the same Classifiers, addition, removal and update of container filters,
but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing
of the protocol headers differ.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a0210ea6440086246aafe632f86498abbb70719a

>   3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 425132e5d7c3770be4a5a39feea5a2f22179b871

> 
> Diff: https://reviews.apache.org/r/29288/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message